Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(SPV-839): add requesterPaymail into upsert contact method #243

Merged
merged 1 commit into from
Jun 24, 2024
Merged

feat(SPV-839): add requesterPaymail into upsert contact method #243

merged 1 commit into from
Jun 24, 2024

Conversation

pawellewandowski98
Copy link
Contributor

Pull Request Checklist

  • 📖 I created my PR using provided : CODE_STANDARDS
  • 📖 I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • ✅ I have provided tests for my changes.
  • 📝 I have used conventional commits.
  • 📗 I have updated any related documentation.
  • 💾 PR was issued based on the Github or Jira issue.

Description

  • Add requesterPaymail to UpsertContact method. It fixes problem with adding contact when user have more than one paymail

@pawellewandowski98 pawellewandowski98 self-assigned this Jun 24, 2024
@pawellewandowski98 pawellewandowski98 requested a review from a team as a code owner June 24, 2024 08:26
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 24, 2024 •
edited
Loading

Manual Tests

💚 Manual testing by @chris-4chain resulted in success.

@pawellewandowski98 pawellewandowski98 changed the title feat(SPV-846): add requesterPaymail into upsert contact method feat(SPV-839): add requesterPaymail into upsert contact method Jun 24, 2024
@chris-4chain chris-4chain added the tested PR was tested by a team member label Jun 24, 2024
@pawellewandowski98 pawellewandowski98 merged commit 435c0e3 into main Jun 24, 2024
9 of 10 checks passed
@pawellewandowski98 pawellewandowski98 deleted the feat-846-add-requester-paymail-to-upsert-contact branch June 24, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris-4chain chris-4chain chris-4chain approved these changes

Assignees

@pawellewandowski98 pawellewandowski98

Labels
tested PR was tested by a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pawellewandowski98 @chris-4chain